-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] added PPG quality assessment functionality #987
Conversation
…sessment techniques
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @peterhcharlton , this is a really nice addition, thanks for your contribution! I think the tests may be failing because of the deletion of "PPG_Peaks" from the signals dataframe.
# Prepare output | ||
signals = pd.DataFrame( | ||
{ | ||
"PPG_Raw": ppg_signal, | ||
"PPG_Clean": ppg_cleaned, | ||
"PPG_Rate": rate, | ||
"PPG_Peaks": peaks_signal["PPG_Peaks"].values, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intentionally delete this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably not be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it back I think, not sure why it’s not showing up here: peterhcharlton@1cd76e4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dani! Let's merge then :)
My apologies for not getting back to you sooner. Thank you for your work on this. To address the changes made:
|
Description
This PR aims at adding a new feature: PPG quality assessment. PPG quality assessment functionality has been added, and two initial quality assessment techniques have been included.
Proposed Changes
Checklist