Upgrade USWDS to 3.5.0 #37
Conversation
namanaman
commented
Jun 21, 2023
namanaman
commented
- Upgrades USWDS dependency from 3.0.1 to 3.5.0
- Pulls in new components from USWDS
- Updates README on how to release a new package version
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Hey hey. Not a lot to review here, looks good and is very exciting, but I left some comments about the Readme text and a lot of comments trying to standardize the ends of the USWDS files. However, maybe it is best that we just don't touch those files at all? Not sure, curious to know what you think.
Thanks!
src/components/card/card--flag.njk
Outdated
| </div> | ||
| </div> | ||
| </li> | ||
| </ul> |
There was a problem hiding this comment.
Do we control these files at all? Should we? If so, please add a newline at the end of this file.
There was a problem hiding this comment.
Reverting back to not changing these (see here for context #37 (comment)). But we pull most in automatically from USWDS
src/components/icon/icon--sizes.njk
Outdated
| {% endfor %} | ||
| </tbody> | ||
| </table> | ||
| </div> |
There was a problem hiding this comment.
Please add a newline at the end of the file (if we control these files at all)
src/components/icon/icon.config.yml
Outdated
| - name: zoom_out_map | ||
| meta: "expand fullscreen" | ||
| - name: zoom_out | ||
| meta: "shrink magnifying glass" |
There was a problem hiding this comment.
Please add a newline at the end of the file (if we control these files at all)
| @@ -0,0 +1 @@ | |||
| preview: "@uswds-form" | |||
There was a problem hiding this comment.
Please add a newline at the end of the file (if we control these files at all)
| @@ -0,0 +1 @@ | |||
| preview: "@uswds-form" | |||
There was a problem hiding this comment.
Please add a newline at the end of the file (if we control these files at all)
|
@namanaman I notice two things here: https://pr-37.d6umhtb6a6pvv.amplifyapp.com/components/preview/header--extended.html
Not sure if these are upstream issues or something we introduced |
Noting this does not appear to be the case on the basic header: https://pr-37.d6umhtb6a6pvv.amplifyapp.com/components/detail/header--basic.html |
|
The multiselect accordian doesn't appear to be multiselect: https://pr-37.d6umhtb6a6pvv.amplifyapp.com/components/preview/accordion--multiselectable.html |
There was a problem hiding this comment.
Just noticed... the USWDS repo changed its file structure, so we actually have a bunch of duplicate components now. See here: https://github.com/newjersey/njwds/tree/upgrade-uswds/src/components
Before, they had components in directories prefixed with numbers for sorting, but in a more recent change they removed these numbers, so many components appear with both formats.
Also noticing the most recent main branch in the USWDS repo looks like it's switched to storybook and done away with these components altogether...so I'm not actually sure where these new components are coming from, unless you have them locally from a previous (but more recent) uwds version. https://github.com/uswds/uswds/tree/v3.5.0/src
|
Some discussion here... uswds/uswds#3263 but not finding any clear communications on the rationale or migration strategy... I'd say we just clean up the duplication for now and then revisit what we want to be our upstream system as a more comprehensive task. |
|
@dhcole Thanks for looking into this further, I should have done some more careful inspection of these changes after importing... So it looks like
|
Addresses a low contrast issue
