Add shortnames for crds. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0tbird
approved these changes
May 6, 2019
There was a problem hiding this comment.
Works for me too:
➜ cluster-api git:(jenny/shortnames) k get cl -n mv1a
NAME AGE
mv1a 36m
➜ cluster-api git:(jenny/shortnames) k get ma -n mv1a
NAME PROVIDERID PHASE
mv1a-controlplane-0 aws:////i-00d2ccb6e4f42dc68
mv1a-controlplane-1 aws:////i-0a8683bd77efedefd
mv1a-controlplane-2 aws:////i-094a2c8eb06bffa78
mv1a-nodes-0-748dd44c5-5d6jn aws:////i-0727317b15f82642f
mv1a-nodes-1-7c8778b78f-xq44p aws:////i-012cdf05405dfe989
mv1a-nodes-2-7ff47f8678-mxbvv aws:////i-026cc30928702fe81
➜ cluster-api git:(jenny/shortnames) k get mc -n mv1a
No resources found.
➜ cluster-api git:(jenny/shortnames) k get md -n mv1a
NAME AGE
mv1a-nodes-0 33m
mv1a-nodes-1 33m
mv1a-nodes-2 33m
➜ cluster-api git:(jenny/shortnames) k get ms -n mv1a
NAME AGE
mv1a-nodes-0-748dd44c5 33m
mv1a-nodes-1-7c8778b78f 33m
mv1a-nodes-2-7ff47f8678 33m
sethp-nr
approved these changes
May 6, 2019
w21froster
pushed a commit
that referenced
this pull request
Sep 19, 2024
* Introduce CEL for ClusterClass Variables Signed-off-by: chaunceyjiang <[email protected]> * feat: Implement CEL validation * refactor: Add comments from previous code reviews * chore: Generate CC manifest after fixing list type annotation (#2) * chore: Fix up CRD manifest * fix: Pass through context to CEL funcs * feat: Add CEL admission cost validation * refactor: Add nolint to unbounded * refactor: Fix up new func signature * build: Fix up go mod for tools * fixup! refactor: Apply review feedback * fixup! build: Regenerate openapi spec * fixup! refactor: Apply review feedback * fixup! fix: Regenerate everything * fixup! fix: Apply review feedback * fixup! fix: More review feedback * fixup! refactor: Address review feedback, especially re recursion * fixup! fix: Check total cost * fixup! refactor: Address review feedback - rename testCtx to ctx * CEL: Various improvements (#3) * resolve compile issue after rebase * Some more improvements (#4) --------- Signed-off-by: chaunceyjiang <[email protected]> Co-authored-by: Jimmi Dyson <[email protected]> Co-authored-by: Jimmi Dyson <[email protected]> Co-authored-by: Stefan Büringer <[email protected]> Co-authored-by: Stefan Bueringer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: