Add tests for improver #1081
Merged
Add tests for improver #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hritik14
force-pushed
the
tests
branch
2 times, most recently
from
2b5d1ee to
7f27fc5
Compare
|
@Hritik14 tests are failing on CI , please re-run your tests once on the CI for 3.10 |
Hritik14
force-pushed
the
tests
branch
2 times, most recently
from
2bf5a16 to
5f1b029
Compare
|
@TG1999 This does not make sense. Only re-running the jobs made the tests pass without any code change. |
|
@Hritik14 it seems to me it's a Heisenbug ? |
|
@TG1999 Possibly |
TG1999
force-pushed
the
tests
branch
2 times, most recently
from
c1143af to
cccc233
Compare
Signed-off-by: Hritik Vijay <[email protected]>
Signed-off-by: Hritik Vijay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #612
Signed-off-by: Hritik Vijay [email protected]