Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export keys are not correct #273

Closed
tiejunhu opened this issue Sep 30, 2021 · 4 comments
Closed

export keys are not correct #273

tiejunhu opened this issue Sep 30, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@tiejunhu
Copy link
Contributor

in current recur implementation of export, the result key is somehow got all connected with dot. so instead of "reg, cfg, map, ctx", now the exported keys are "reg, reg.cfg, reg.cfg.map, reg.cfg.map.ctx"

@tiejunhu
Copy link
Contributor Author

tiejunhu commented Oct 8, 2021

I submitted a PR trying to fix this issue. I pass the field to the "async" func and let async call export with this parameter to avoid nested export key.

@janat08
Copy link

janat08 commented May 30, 2022

Should we just put something in docs in the meantime? If this isn't being merged, then point out that file names are wrong, rather than that the filename is the first param to be passed in.

@g-harel
Copy link

g-harel commented Jun 13, 2022

Yes, this took me hours to figure out. Would be very helpful to flag it in the docs with a workaround. Here's what I used:

 const fixedKey = key.split(".").slice(-1)[0];

@ts-thomas ts-thomas self-assigned this Oct 2, 2022
@ts-thomas ts-thomas added the bug Something isn't working label Oct 2, 2022
@ts-thomas
Copy link
Contributor

This is now fixed in v0.7.23
Further improvements to provide Promise.all() compatible export ist coming in next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants