Make exports return a Promise that resolves after last callback was called #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create new variable in document and index exports, which contains a handle for Promise resolve call. When Index is exported directly, then `field` argument is `undefined`, thus the Promise is resolved inside the index export method. When Document is exported, then `field` argument is set, thus preventing Promise to be resolved inside Index export method before all indexes, store, and tags are exported.
|
Looks great, thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new variable in document and index exports, which contains a handle for Promise resolve call. When Index is exported directly, then
fieldargument isundefined, thus the Promise is resolved inside the index export method. When Document is exported, thenfieldargument is set, thus preventing Promise to be resolved inside Index export method before all indexes, store, and tags are exported.There are no breaking changes, although method signature must be updated in documentation, since a Promise is now returned.
Fixes #353