Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): Export types related to email and credential providers #1666

Closed
wants to merge 1 commit into from

Conversation

jgeurts
Copy link

@jgeurts jgeurts commented Apr 7, 2021

What: Export types for Email and Credential providers

Why: Simplify custom adapter code

How: Added export keyword before types/interfaces in providers.d.ts

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Related: #1649

@vercel
Copy link

vercel bot commented Apr 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/AJufy9HEDJeZRLGDw2pAvnmzFGwC
✅ Preview: https://next-auth-git-fork-jgeurts-export-email-types-nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview April 7, 2021 15:39 Inactive
@balazsorban44 balazsorban44 added the TypeScript Issues relating to TypeScript label Apr 7, 2021
Copy link
Collaborator

@ubbe-xyz ubbe-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jgeurts 💚 . To have a bit more context, could you explain what are the problems you're trying to address when exporting these types ( as maybe there's no need )?

Bear in mind that the actual types still live at DefinitivelyTyped and the types here are part of a migration that is WIP (so even if we merge these updates, you won't be able to benefit from them just yet 😌)

@ubbe-xyz ubbe-xyz added the incomplete Insufficient reproduction. Without more info, we won't take further actions/provide help. label Apr 9, 2021
@jgeurts
Copy link
Author

jgeurts commented Apr 9, 2021

I have a custom adapter that defines functions for verification requests. Currently, I duplicate the type definitions, but it would be handy to import them from next-auth. I’ll add a PR to DefinitelyTyped in the coming week, but figured I’d start here in case this goes through before I make the other pr. Hope that helps!

@ubbe-xyz ubbe-xyz removed the incomplete Insufficient reproduction. Without more info, we won't take further actions/provide help. label Apr 11, 2021
Copy link
Collaborator

@ubbe-xyz ubbe-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 😊 , I think we can merge here and no need to raise the PR on DefinitivelyTyped.

@balazsorban44
Copy link
Member

Would wait to merge until we reviewed #1690

@balazsorban44
Copy link
Member

As far as I can tell, all these will be redundant/are addressed in #1690, so closing. Tell me if something is missing still!

@jgeurts jgeurts deleted the export-email-types branch April 17, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeScript Issues relating to TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants