-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ts): Export types related to email and credential providers #1666
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/AJufy9HEDJeZRLGDw2pAvnmzFGwC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jgeurts 💚 . To have a bit more context, could you explain what are the problems you're trying to address when exporting these types ( as maybe there's no need )?
Bear in mind that the actual types still live at DefinitivelyTyped and the types here are part of a migration that is WIP (so even if we merge these updates, you won't be able to benefit from them just yet 😌)
I have a custom adapter that defines functions for verification requests. Currently, I duplicate the type definitions, but it would be handy to import them from next-auth. I’ll add a PR to DefinitelyTyped in the coming week, but figured I’d start here in case this goes through before I make the other pr. Hope that helps! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 😊 , I think we can merge here and no need to raise the PR on DefinitivelyTyped.
Would wait to merge until we reviewed #1690 |
As far as I can tell, all these will be redundant/are addressed in #1690, so closing. Tell me if something is missing still! |
What: Export types for Email and Credential providers
Why: Simplify custom adapter code
How: Added
export
keyword before types/interfaces in providers.d.tsChecklist:
Related: #1649