Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type definitions for JWTOptions.verificationOptions #1715

Closed

Conversation

recurser
Copy link

@recurser recurser commented Apr 13, 2021

What:

This PR adds missing types for passing verificationOptions when working with JWT tokens. See jwt.js for context.

The jose types in question are here:

It was originally submitted as DefinitelyTyped#51878, but @lluia suggested I move it here instead.

Why:

I would like to pass verificationOptions, and currently I have to monkey-patch the types to do it.

How:

Added missing type definitions.

Checklist:

  • Documentation N/A
  • Tests N/A (I think?)
  • Ready to be merged

@vercel
Copy link

vercel bot commented Apr 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/ERYfjWZmDed2KidyXSepUcKr9Y9n
✅ Preview: https://next-auth-git-fork-recurser-add-jwt-verification-op-6abae6.vercel.app

@vercel vercel bot temporarily deployed to Preview April 13, 2021 13:00 Inactive
@recurser recurser changed the title Add missing types for JWTOptions.verificationOptions Add missing type definitions for JWTOptions.verificationOptions Apr 13, 2021
@balazsorban44
Copy link
Member

balazsorban44 commented Apr 17, 2021

#1690 will address this:

verificationOptions?: JoseJWT.VerifyOptions<false>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants