Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken select/label ID/name mismatch #900

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fix broken select/label ID/name mismatch #900

merged 1 commit into from
Aug 30, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 30, 2022 •
edited
Loading

  • name did not match the for on the label
  • id was missing so clicking the label didn't activate the select dropdown

Fix #897

@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Aug 30, 2022
@nickvergessen nickvergessen marked this pull request as ready for review August 30, 2022 06:56
@nickvergessen nickvergessen merged commit 94b821f into master Aug 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/897/fix-broken-select-label-id branch August 30, 2022 07:05
@nickvergessen nickvergessen mentioned this pull request Aug 30, 2022
Closed
@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review bug feature: settings
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

Conflicting HTML ID attribute after update (+EMail Notification change)
2 participants
@nickvergessen @CarlSchwan