Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to subpage of other collective opened in Files app while editing #409

Closed
mejo- opened this issue Oct 25, 2022 · 5 comments
Closed

Link to subpage of other collective opened in Files app while editing #409

mejo- opened this issue Oct 25, 2022 · 5 comments

Comments

@mejo-
Copy link
Member

mejo- commented Oct 25, 2022

In GitLab by @susnux on Oct 25, 2022, 11:46

First, this is different to https://gitlab.com/collectivecloud/collectives/-/issues/408 as it affects all browser and only happens in the "edit"-mode


When in the editing a page an clicking on a link, a new tab is opened, but instead of that other page the file list (root) is opened.
I think this is because the links are relative to collectives but on the files app the files are within the collectives directory.

Tested on NC 24.0.6 with Firefox 104 and Firefox for Android.

@mejo- mejo- added bug Something isn't working feature: link handling labels Feb 15, 2023
@mejo-
Copy link
Member Author

mejo- commented Feb 28, 2023

Same here, I'm unable to reproduce. Did I miss something?

  1. Created a collective, copied the link
  2. Created another collective
  3. Created a subpage in the second collective, put link to first collective in this page
  4. In edit mode, clicked on the link to the other collective

With all browsers I tested (Firefox Desktop, Chromium Desktop, Chromium Android) the linked collective was opened (in a new tab, as expected in edit mode). I didn't spot a redirection to the files app.

I tested on latest Nextcloud (development branches, 26) and on Nextcloud 25.0.4.

Maybe the issues have been fixed along the way 🤔

@mejo-
Copy link
Member Author

mejo- commented Feb 28, 2023

@susnux ☝️

@susnux
Copy link
Contributor

susnux commented Feb 28, 2023

Kind of fixed, tested this on NC25:

In edit mode the collective page is opened in the viewer / text app

Is this expected?

@mejo-
Copy link
Member Author

mejo- commented Mar 1, 2023

Indeed, in edit mode Text opens any links with fileId=... in files app straight away due to nextcloud/text#2268.

I opened issue nextcloud/text#3857 to track this upstream.

@mejo- mejo- changed the title Link to other collective does not work while editing Link to subpage of other collective opened in Files app while editing Mar 1, 2023
@mejo-
Copy link
Member Author

mejo- commented Mar 2, 2023

The remaining part of this issue is tracked in nextcloud/text#3857 and PR nextcloud/text#3870 is on its way to git it fixed.

@mejo- mejo- closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants