Only open direct link files if link points to Files app #3870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable25 |
1 flaky tests on run #8911 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mejo-
force-pushed
the
fix/collectives_fileid_links
branch
from
ec1c603 to
4baa252
Compare
mejo-
force-pushed
the
fix/collectives_fileid_links
branch
5 times, most recently
from
734475e to
7d55553
Compare
julien-nc
approved these changes
Mar 6, 2023
Until now, we always opened direct link files when a link contained a `fileId` query parameter. This breaks e.g. links to pages from the Collectives app, which contain `fileId` parameters as well. Limit opening direct file link to links that point to the Files app. Fixes: #3857 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/collectives_fileid_links
branch
from
7d55553 to
ed89dd1
Compare
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
/backport ed89dd1 to stable25 |
|
/backport ed89dd1 to stable26 |
1 task
|
/backport ed89dd1 to stable25 |
|
The backport to stable25 failed. Please do this backport manually. |
2 similar comments
|
The backport to stable25 failed. Please do this backport manually. |
|
The backport to stable25 failed. Please do this backport manually. |
|
Manual backport to stable25: #3905 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we always opened direct link files when a link contained a
fileIdquery parameter. This breaks e.g. links to pages from the Collectives app, which containfileIdparameters as well.Limit opening direct file link to links that point to the Files app.
Fixes: #3857
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)