-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add headings for slides #852
Conversation
b46e565
to
108de7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say just using the position of the slogan (on the blue background above) is nicer for the header. Then we don't use more space, and the text is not just all the same on all pages.
Text I'd suggest for each slide:
- A safe home for your data (like now but with capital A)
- Extend your cloud (like the page title)
- Stay in sync (like the page title)
- Get support or participate (as you suggested)
I get your point but the heading is then not visually connected to the content anymore (since the header is visually separated and the slogan also directly connected to the logo instead of the content) which it should be imho... So leaving it in the main content is more easy to understand imo... |
Signed-off-by: Simon L <[email protected]>
056c5fa
to
348d0f0
Compare
Should be adjusted |
We need to get the slides simpler though. :) I think having the heading in the blue part will be fine. We can also bold it for more presence. But adding more text makes it quite cluttered. |
all right. Let me investigate then how we could add this to the header... |
acf4c10
to
dedc356
Compare
Signed-off-by: Simon L <[email protected]>
dedc356
to
04ffa01
Compare
@jancborchardt I investigated a bit and due to how the app is currently built: Rendering in Vue but templates in PHP, I currently don't see an good way to insert a title from the template into the header of the modal (despite hacky ways) without rewriting quite some code. (which I am not sure about how to do currently). So would it be okay to leave it in the body for now or do we rather want to postpone this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this for now :)
Close #107