Add lastUpdated property to Form

[Chartman123]

This fixes #1462

Signed-off-by: Christian Hartmann [email protected]

[Chartman123]

@jotoeri could you please point me in the right direction, why my setLastUpdatedTimestamp function in the forms service doesn't work?

[jotoeri]

You need to update the Form Entity to the Db with $this->formMapper->update($form);. Currently you only retrieve the Form-Entity, set the Timestamp on it, but don't write it back to Db.
And you first need to store the form entity you get from findById. 😉

[Chartman123]

And you first need to store the form entity you get from findById. wink

🤦🏻

$this->formMapper->update($form);

Thanks, this was the missing part.

[codecov]

Codecov Report

Merging #1479 (4862112) into main (0eefbbe) will decrease coverage by 0.10%.
The diff coverage is 20.45%.

❗ Current head 4862112 differs from pull request most recent head d179439. Consider uploading reports for the commit d179439 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1479      +/-   ##
============================================
- Coverage     39.56%   39.47%   -0.10%     
- Complexity      556      560       +4     
============================================
  Files            53       54       +1     
  Lines          2320     2333      +13     
============================================
+ Hits            918      921       +3     
- Misses         1402     1412      +10     

[Chartman123]

@jotoeri The backend stuff should be ready now. However, I'm not sure how to proceed with the frontend, so that a changed form for example will also result in a reordered forms list in the AppNavigation. Shall we split this into a second PR?

[jotoeri]

Hmm, to avoid confusion, i think we should shift it up, once updated/edited. That will of course not cover submissions, but will make clear the principle.

• Should suffice to just use the timestamp on the Frontend within a session, no need to have the exact timestamp of the backend.
• To not pass the event everywhere through our components you can also use the nextcloud/event-bus package.

And i wouldn't do it separately. Its closely connected.

[Chartman123]

@jotoeri It's already working for updated form properties. However, I still get some errors when updating question properties and question options. Perhaps you could already have a look at it... I will only be able to get back to work tomorrow in the evening.

[susnux]

I still get some errors when updating question properties and question options.

Do you still get those errors? For me it works perfectly when changing question properties like required or shuffle options.

[Chartman123]

@susnux I figured out the question related problems... now just the options/answers are missing.

I'm a little clueless what is triggered by the $emit('update:options',...) in dropdown and multiple questions. There is no @update:options in any of the vue components...

[susnux]

I'm a little clueless what is triggered by the $emit('update:options',...) in dropdown and multiple questions. There is no @update:options in any of the vue components...

I think it is used in views/Create.vue: v-bind.sync="form.questions[index]". As this should bind :options.sync.

[Chartman123]

@susnux @jotoeri I've now added the re-sorting for changed options. My last problem is that this also moves the form up just on clicking inside the "add new option" input box. At this time, the options haven't change in the database, so basically the sorting is "wrong".

[Chartman123]

@susnux Your new ApiControllerTest is killing me... 😆 Could you please help me fix the failing checks here?

[susnux]

You need to mock the time() function as the controller sets the lastUpdated value based on it. (see my commit)

[Chartman123]

Thank you! Now I can polish the integration tests and then everything should be fine :)

[jotoeri]

So - now got into this one. Two small comments, maybe also squash a bit, but apart from that, it should be fine by me.

[Chartman123]

So - now got into this one. Two small comments, maybe also squash a bit, but apart from that, it should be fine by me.

Fixed them and squashed the commits. I think it's ready to go now :)

[jancborchardt]

Good stuff, thank you @Chartman123! :) (Can't review the code, so only leaving comment instead of approval.)

[susnux]

👍

[susnux]

@Chartman123
I tested this using mariaDB, so I did not noticed it, but this breaks updating a server that runs on SQLite.
The comment option on the new database column does not work with SQLite:
https://www.doctrine-project.org/projects/doctrine-dbal/en/current/reference/schema-representation.html#common-options

In ExceptionConverter.php line 82:
                                                                                                     
  An exception occurred while executing a query: SQLSTATE[HY000]: General error: 1 incomplete input  
                                                                                                     

In Exception.php line 30:
                                                      
  SQLSTATE[HY000]: General error: 1 incomplete input  
                                                      

In Connection.php line 72:
                                                      
  SQLSTATE[HY000]: General error: 1 incomplete input  
                                                      

I do not know why a clean install work (no forms installed before), it only fails if a partial migration is required.

[Chartman123]

Strange, I copied the code from some older migration... 🙈