Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mailto): Handle BCC recipients only #10433

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(mailto): Handle BCC recipients only #10433

merged 1 commit into from
Dec 2, 2024
+17 −1

Conversation

ChristophWurst
Copy link
Member

When using the Send email as BCC feature in Contacts, Mail failed at two steps:

  • The PHP redirect that always assumed a ordinary recipient (to)
  • The frontend that didn't pass BCC information to the composer modal

@ChristophWurst ChristophWurst self-assigned this Dec 2, 2024
@GretaD
Copy link
Contributor

GretaD commented Dec 2, 2024

  • The frontend that didn't pass BCC information to the composer modal

how do you tell that? What is expected for me to see to test this pr

@ChristophWurst
Copy link
Member Author

Test main and you will get an error page. Test this branch and you will get the expected bcc recipients prefilled in the composer.

  1. Open Contacts
  2. Create contact 1 with an email address and a group
  3. Create contact 2 with an email address and a group
  4. Use Send email via BCC

GretaD
GretaD approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works

@GretaD GretaD merged commit 77ecbeb into main Dec 2, 2024
35 checks passed
@GretaD GretaD deleted the fix/mailto/bcc-recipients branch December 2, 2024 13:49
@ChristophWurst
Copy link
Member Author

/backport to stable4.1

@ChristophWurst
Copy link
Member Author

/backport to stable4.0

@backportbot backportbot bot mentioned this pull request Dec 2, 2024
Merged
@ChristophWurst
Copy link
Member Author

/backport to stable3.7

This was referenced Dec 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review bug regression
Projects
💌 📅 👥 Groupware team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @GretaD