Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: phishing detection fixes #10476

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

hamza221
Copy link
Contributor

fix #10452
fix #10423

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to cover the two cases with unit tests?

@hamza221 hamza221 force-pushed the feat/phishing-detection-fixes branch from 338f0ed to e771d4c Compare December 11, 2024 08:38
@hamza221 hamza221 requested a review from GretaD as a code owner December 11, 2024 08:38
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick to prevent new technical debt

tests/Unit/Service/Phishing/DateCheckTest.php Outdated Show resolved Hide resolved
@hamza221 hamza221 force-pushed the feat/phishing-detection-fixes branch from e771d4c to 89edd80 Compare December 11, 2024 09:29
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221 hamza221 force-pushed the feat/phishing-detection-fixes branch from 89edd80 to dba8aff Compare December 11, 2024 10:22
@ChristophWurst ChristophWurst merged commit bd94188 into main Dec 11, 2024
35 checks passed
@ChristophWurst ChristophWurst deleted the feat/phishing-detection-fixes branch December 11, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [mail] Error: Failed to parse time string URLs in angle brackes trigger phishing detection
2 participants