Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slash command to mail composer #8898

Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 27, 2023

image
image

@kesselb kesselb force-pushed the enh/CKEditor-slash-commands-plugin branch 2 times, most recently from 152a10f to c38f327 Compare September 27, 2023 19:58
@hamza221
Copy link
Contributor

hamza221 commented Oct 2, 2023

@kesselb I tried generalizing the plugin by adding a 'trigger' argument to insertLink() so it can also work with emoji picker and it's working flawlessly locally.
Do you think it's a good way to go. If so I'll push a commit here then merge it with the other branch.

@hamza221
Copy link
Contributor

hamza221 commented Oct 2, 2023

I pushed it anyways we can reset it, if there's a problem , in the meantime I'm checking the mentions plugin

@kesselb
Copy link
Contributor Author

kesselb commented Oct 2, 2023

Sounds good to me 👍

If possible, please add a test.

As example, the test for the signature plugin: https://github.com/nextcloud/mail/blob/main/src/tests/unit/components/SignaturePlugin.spec.js (it's also a command called from TextEditor component).

@hamza221
Copy link
Contributor

hamza221 commented Oct 3, 2023

The mention plugin works, I did a poc in my last commit for the emoji picker, It still needs some work ui wise. With the next commit I'll add slash commands, fix Ui and add tests then hopefully the feature would be ready

@hamza221 hamza221 force-pushed the enh/CKEditor-slash-commands-plugin branch from a1e8482 to 82af192 Compare October 11, 2023 15:43
@hamza221
Copy link
Contributor

hamza221 commented Oct 11, 2023

@kesselb are you okay with merging and doing the review on the main Pr?

@kesselb kesselb merged commit 05947f2 into enh/CKEditor-slash-commands Oct 11, 2023
28 checks passed
@kesselb kesselb deleted the enh/CKEditor-slash-commands-plugin branch October 11, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants