Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(classification): Delete historic data #9001

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(classification): Delete historic data #9001

merged 1 commit into from
Oct 25, 2023

Conversation

ChristophWurst
Copy link
Member

It's interesting to analyze for improvements but otherwise just bloats app data and the database.

How to test

  1. Set up an account
  2. Run mail:account:train 10x
  3. Wait two months and a day (or change oc_mail_classifiers.created_at timestamps in the database)
  4. Run SELECT COUNT(*) FROM oc_mail_classifiers and remember the number
  5. Run occ mail:clean-up
  6. Run SELECT COUNT(*) FROM oc_mail_classifiers and compare it to the number before

@ChristophWurst ChristophWurst added bug 3. to review feature:priority inbox Features and bugs related to the "priority inbox" feature labels Oct 25, 2023
@ChristophWurst ChristophWurst self-assigned this Oct 25, 2023
miaulalala
miaulalala approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gud

@ChristophWurst ChristophWurst merged commit 09b7d46 into main Oct 25, 2023
30 of 31 checks passed
@ChristophWurst ChristophWurst deleted the fix/classification/delete-historic-data branch October 25, 2023 14:19
@ChristophWurst
Copy link
Member Author

/backport to stable3.4

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 25, 2023
Merged
@ChristophWurst ChristophWurst mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesGGE JohannesGGE JohannesGGE approved these changes

@miaulalala miaulalala miaulalala approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review bug feature:priority inbox Features and bugs related to the "priority inbox" feature
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @miaulalala @JohannesGGE