fix integration tests

[Grotax]

• Resolves: Tests Failing

Summary

fix ?? operator, I'm not sure what ??= does but apparently not what we wanted. ?? is evaluating if the expression to the left is null and assigns the default value on the right.
"null coalescing" operator
https://www.php.net/manual/en/language.operators.comparison.php#language.operators.comparison.coalesce

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Changelog entry added for all important changes.

[SMillerDev]

https://wiki.php.net/rfc/null_coalesce_equal_operator is what it should be

[anoymouserver]

The null coalescing assignment operator does essentially this:
$httpLastModified = $httpLastModified ?? (new DateTime("-1 year"))->format(DateTime::RSS);

https://www.php.net/manual/en/migration74.new-features.php#migration74.new-features.core.null-coalescing-assignment-operator - However I also couldn't find it in the docs itself.

Your current code does something different, since it nerver assigns the value.

[Grotax]

hmm I see but why does the test fail without this change? I will try
$httpLastModified = $httpLastModified ?? (new DateTime("-1 year"))->format(DateTime::RSS);

[Grotax]

with
$httpLastModified = $httpLastModified ?? (new DateTime("-1 year"))->format(DateTime::RSS);

it also fails, I'm clueless. That seems to mean that when we pass the date to feed-io it will handle the call somehow in a different way and not throw the exception

[Grotax]

Okay after your input I thought again what else could cause this and I followed the feed-io code.

Feed-Io adds a filter based on the date we give it.

The feed we test with just happens to have dates about 1 year ago. So with every day less items where considered as valid in that feed until even the last item was out.
The feed returned by feed-io is empty. It does still notice the error and we have it in the DB but since there is no Item that is valid or to be considered for further actions everything returns ok :D

As temporary fix I updated the dates to 2023 and it works again.

[Grotax]

Okay 2099 should be fine for a while, the next maintainer can adjust the date again if needed.