Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background email job for disabled users #1255

Merged

Conversation

nickvergessen
Copy link
Member

Before the timestamp was increased with every run for disabled users, so in our database we had an entry with next send time set to 2147477417 which is Tue Jan 19 2038 01:30:17 GMT+0000 and fails to increase further resulting in:

Numeric value out of range: 1264 Out of range value for column 'next_send_time' at row

But we should only increase the disabled users when the send time was triggered, like we do for normal users. So here is the fix and a migration to decrease the send time for users that have the value already too far in the future.

Fix #1254

@nickvergessen
Copy link
Member Author

/backport to stable24

@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9470 was 9300 (+1.82%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen force-pushed the bugfix/1254/fix-background-job-for-disabled-users branch from 75ace8d to f0ad2fb Compare August 26, 2022 06:15
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9470 was 9300 (+1.82%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen
Copy link
Member Author

/backport to stable23

@nickvergessen nickvergessen merged commit c91c44d into master Aug 26, 2022
@nickvergessen nickvergessen deleted the bugfix/1254/fix-background-job-for-disabled-users branch August 26, 2022 06:45
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numeric value out of range: 1264 Out of range value for column 'next_send_time' at row
2 participants