Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from iconv to mb_convert_encoding #1967

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Switch from iconv to mb_convert_encoding #1967

merged 1 commit into from
Jan 10, 2022

Conversation

Keessaus
Copy link
Contributor

@Keessaus Keessaus commented Jan 7, 2022

Switches all (three) uses of iconv to using mb_convert_encoding to resolve #1966.

@juliusknorr juliusknorr merged commit d9ebd3b into nextcloud:master Jan 10, 2022
@juliusknorr
Copy link
Member

/backport to stable23

@juliusknorr
Copy link
Member

/backport to stable4

@juliusknorr juliusknorr added 1. to develop Waiting for a developer bug Something isn't working 4. to release Ready to release, can be waiting for the tests to finish and removed 1. to develop Waiting for a developer labels Jan 10, 2022
This was referenced Jan 10, 2022
Merged
Merged
@juliusknorr
Copy link
Member

Thanks a lot for your pull request @Keessaus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
4. to release Ready to release, can be waiting for the tests to finish bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save as does not work: iconv doesn't support UTF-7 on Alpine
2 participants
@Keessaus @juliusknorr