feat: use autocomplete api for mentions #4210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
force-pushed
the
fix/mention-autocomplete
branch
from
e104f5c to
588a56e
Compare
juliusknorr
reviewed
Nov 12, 2024
elzody
force-pushed
the
fix/mention-autocomplete
branch
from
588a56e to
7600e7e
Compare
juliusknorr
force-pushed
the
fix/mention-autocomplete
branch
from
3b082db to
a095bda
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
juliusknorr
force-pushed
the
fix/mention-autocomplete
branch
from
a095bda to
1d4c813
Compare
juliusknorr
approved these changes
Dec 13, 2024
juliusknorr
added
enhancement
|
@elzody Maybe you can check how far we should backport this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Try to use the autocomplete API to search for the user by display name instead so that the instance sharing settings regarding autocompletion are respected.
Checklist