Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Repair and Migrator events to IEventDispatcher #33640

Merged
merged 12 commits into from
Aug 30, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 22, 2022

See #32128
This also fixes #33264

@come-nc come-nc added this to the Nextcloud 25 milestone Aug 22, 2022
@come-nc come-nc self-assigned this Aug 22, 2022
@come-nc come-nc linked an issue Aug 22, 2022 that may be closed by this pull request
2 tasks
@come-nc
Copy link
Contributor Author

come-nc commented Aug 22, 2022

It seems \OC\DB\Migrator::checkTable is actually never dispatched, is it?

Not since a2f3077

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

lib/private/Updater.php Fixed Show fixed Hide fixed
lib/private/Updater.php Fixed Show fixed Hide fixed
lib/private/Updater.php Fixed Show fixed Hide fixed
lib/private/Updater.php Fixed Show fixed Hide fixed
lib/private/Updater.php Fixed Show fixed Hide fixed
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 38 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 18 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 18 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 18 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 18 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

core/ajax/update.php Fixed Show fixed Hide fixed
core/ajax/update.php Fixed Show fixed Hide fixed
core/ajax/update.php Fixed Show fixed Hide fixed
core/ajax/update.php Fixed Show fixed Hide fixed
core/ajax/update.php Fixed Show fixed Hide fixed
core/ajax/update.php Fixed Show fixed Hide fixed
core/ajax/update.php Fixed Show fixed Hide fixed
core/ajax/update.php Fixed Show fixed Hide fixed
core/ajax/update.php Fixed Show fixed Hide fixed
@come-nc come-nc force-pushed the fix/fix-symfony-event-typing branch from 931993a to 123d85f Compare August 23, 2022 08:34
@come-nc come-nc changed the title Fix symfony event typing Port Repair and Migrator events to IEventDispatcher Aug 23, 2022
@come-nc come-nc requested a review from CarlSchwan August 23, 2022 10:22
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 23, 2022
@come-nc come-nc requested review from a team and PVince81 and removed request for a team August 23, 2022 10:22
core/Command/Upgrade.php Outdated Show resolved Hide resolved
core/ajax/update.php Outdated Show resolved Hide resolved
@blizzz blizzz mentioned this pull request Aug 24, 2022
@come-nc come-nc force-pushed the fix/fix-symfony-event-typing branch 2 times, most recently from 5fbe1df to 3808f0c Compare August 25, 2022 10:15
@come-nc come-nc requested a review from nickvergessen August 25, 2022 10:17
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but looks good in general

core/Command/Maintenance/Repair.php Outdated Show resolved Hide resolved
core/ajax/update.php Outdated Show resolved Hide resolved
lib/private/DB/MigratorExecuteSqlEvent.php Show resolved Hide resolved
lib/private/Repair/Events/RepairAdvanceEvent.php Outdated Show resolved Hide resolved
lib/private/Repair/Events/RepairInfoEvent.php Show resolved Hide resolved
lib/private/Repair/Events/RepairStepEvent.php Show resolved Hide resolved
@come-nc come-nc force-pushed the fix/fix-symfony-event-typing branch from 3d5cd2b to 4ac8173 Compare August 25, 2022 14:15
@come-nc
Copy link
Contributor Author

come-nc commented Aug 25, 2022

Tested web updater with a no-problem update, seemed fine.
Need to test app update, error update and cli update I suppose.

@come-nc come-nc requested a review from nickvergessen August 30, 2022 09:51
@come-nc
Copy link
Contributor Author

come-nc commented Aug 30, 2022

cli upgrade works fine. Not sure how to test app upgrade or buggy upgrade, I test by switching branches so there is no actual download happenning.

@come-nc come-nc merged commit f56ecf9 into master Aug 30, 2022
@come-nc come-nc deleted the fix/fix-symfony-event-typing branch August 30, 2022 12:47
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 30, 2022
@blizzz blizzz mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update via UI breaks with future version of symfony/event-dispatcher
4 participants