Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for opcache.file_cache_only=1 #35365

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Check for opcache.file_cache_only=1 #35365

merged 1 commit into from
Feb 15, 2023

Conversation

MichaIng
Copy link
Member

@MichaIng MichaIng commented Nov 23, 2022 •
edited
Loading

Summary

Check for opcache.file_cache_only=1 which disables shared memory based OPcache with disk file cache used only, if enabled. In this case, opcache.memory_consumption and others do not apply, so show the correct performance recommendation to enable memory cache.

Checklist

@MichaIng MichaIng added enhancement 3. to review Waiting for reviews labels Nov 23, 2022
@MichaIng MichaIng added this to the Nextcloud 26 milestone Nov 23, 2022
@MichaIng MichaIng requested a review from CarlSchwan as a code owner November 23, 2022 14:38
@MichaIng MichaIng mentioned this pull request Nov 23, 2022
Closed
9 tasks
szaimen
szaimen approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen szaimen requested review from a team, ArtificialOwl and come-nc and removed request for a team November 23, 2022 14:48
@MichaIng MichaIng added the php Pull requests that update Php code label Jan 16, 2023
@MichaIng MichaIng force-pushed the enh/check-opcache-file_cache_only branch from 8c54757 to a12f874 Compare January 16, 2023 14:23
@MichaIng MichaIng force-pushed the enh/check-opcache-file_cache_only branch from a12f874 to ce33066 Compare January 20, 2023 21:07
@MichaIng MichaIng enabled auto-merge January 20, 2023 21:14
@MichaIng MichaIng added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 20, 2023
@MichaIng MichaIng force-pushed the enh/check-opcache-file_cache_only branch from ce33066 to aef5b76 Compare January 23, 2023 11:50
@MichaIng
Copy link
Member Author

/backport to stable25

@MichaIng
Copy link
Member Author

/backport to stable24

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@MichaIng
Check for opcache.file_cache_only=1
7e725c5 
which disables shared memory based OPcache with disk file cache used only, if enabled. In this case, "opcache.memory_consumption" and others do not apply, so show the correct performance recommendation to enable memory cache.

Signed-off-by: MichaIng <[email protected]>
@MichaIng MichaIng force-pushed the enh/check-opcache-file_cache_only branch from aef5b76 to 7e725c5 Compare February 15, 2023 17:56
@MichaIng MichaIng merged commit b36a31c into master Feb 15, 2023
@MichaIng MichaIng deleted the enh/check-opcache-file_cache_only branch February 15, 2023 18:40
This was referenced Feb 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@szaimen szaimen szaimen approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement php Pull requests that update Php code
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

[Bug]: Unsupported opcache.file_cache_only?
3 participants
@MichaIng @szaimen @come-nc