Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Change X-Robots-Tag header from "none" to "noindex, nofollow" #36750

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #36689

@backportbot-nextcloud backportbot-nextcloud bot added bug enhancement pending documentation This pull request needs an associated documentation update privacy labels Feb 16, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.10 milestone Feb 16, 2023
@szaimen
Copy link
Contributor

szaimen commented Feb 16, 2023

Not sure about this backport as this woild be a breaking change on some instances?

@MichaIng
Copy link
Member

#36749 (comment)

@blizzz blizzz mentioned this pull request Mar 13, 2023
@blizzz
Copy link
Member

blizzz commented Mar 15, 2023

needs another reviewer

@blizzz blizzz merged commit 7e48530 into stable24 Mar 15, 2023
@blizzz blizzz deleted the backport/36689/stable24 branch March 15, 2023 13:50
@DaphneMuller
Copy link

Hello!
Thank you for your work on this! I noticed that your PR still has the label 'documentation'. I'm not sure if you already had a look at the documentation for your PR, but at Nextcloud we strive to document changes that affect other app developers or other admins before the release takes place, and I'm pinging you with the hope to get this done.

Are you familiar with our documentation process already?
Changes that affect app developers should be documented here:
https://docs.nextcloud.com/server/27/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.html

Changes that affect administrators should be documented here:
https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_27.html

While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here:
https://docs.nextcloud.com/server/27/developer_manual/prologue/compatibility_app_ecosystem.html#documentation-procedures-of-changes-that-affect-app-developers

If all your documentation efforts are done, please remove the label 'documentation' and check the checkbox in your opening note and I'll stop bugging you :)

Many thanks in advance and thanks again for your work!

@kesselb kesselb removed the pending documentation This pull request needs an associated documentation update label May 30, 2023
@ChristophWurst
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants