Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Convert tag id to number (closing #35645) #36887

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[stable25] Convert tag id to number (closing #35645) #36887

merged 1 commit into from
Feb 28, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 28, 2023 •
edited by blizzz
Loading

  • ⚠️ This backport had conflicts and is incomplete

backport of #36866

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.5 milestone Feb 28, 2023
@R0Wi
Copy link
Member

R0Wi commented Feb 28, 2023

@szaimen in general this LGTM. How do we deal with the generated js files when backporting? Think that made the conflict.

@szaimen
Copy link
Contributor

szaimen commented Feb 28, 2023

/compile amend /

@R0Wi @nextcloud-command
Convert tag ids to number
163b86b 
Fix for #35645

Signed-off-by: GitHub <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@R0Wi R0Wi enabled auto-merge February 28, 2023 10:12
@blizzz blizzz added the 4. to release Ready to be released and/or waiting for tests to finish label Feb 28, 2023
@R0Wi R0Wi merged commit a85639f into stable25 Feb 28, 2023
@R0Wi R0Wi deleted the backport/36866/stable25 branch February 28, 2023 10:26
@blizzz blizzz mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R0Wi R0Wi R0Wi approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 25.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@R0Wi @szaimen @artonge @blizzz