Audit the tag creator #40163
Merged
Audit the tag creator #40163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im not sure how to continue here: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -189,6 +190,13 @@ | |||
| $appActions->runCommand($event->getArguments()); | |||
| }); | |||
| } | |||
| private function tagHooks(IAuditLogger $logger, | |||
| IEventDispatcher $eventDispatcher): void { | |||
| $eventDispatcher->addListener(\OCP\SystemTag\ManagerEvent::EVENT_CREATE, function (\OCP\SystemTag\ManagerEvent $event) use ($logger) { | |||
Check notice
Code scanning / Psalm
DeprecatedConstant Note
There was a problem hiding this comment.
nice that we deprecated it without having a replacement 😅
There was a problem hiding this comment.
Well I deprecated all of the old style to make people aware that we need to update it at some point.
Also it allows us to drop the old thing sooner :P
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
GretaD
force-pushed
the
enhanc/audit-tag-creator
branch
from
95a1f06 to
f4227f6
Compare
GretaD
added
3. to review
nickvergessen
approved these changes
May 16, 2024
susnux
force-pushed
the
enhanc/audit-tag-creator
branch
from
64b6a5b to
4d3bd0a
Compare
susnux
approved these changes
Jul 9, 2024
susnux
force-pushed
the
enhanc/audit-tag-creator
branch
from
ccf27ca to
feb227f
Compare
susnux
added
4. to release
Co-authored-by: greta <[email protected]> Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: greta <[email protected]>
AndyScherzinger
force-pushed
the
enhanc/audit-tag-creator
branch
from
feb227f to
d590373
Compare
AndyScherzinger
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist