Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use background to increase overlay contrast #41426

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Use background to increase overlay contrast #41426

merged 1 commit into from
Nov 13, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Nov 13, 2023 •
edited
Loading

And limit it to files.

Part of step 2 of #40242

image
Screenshot from 2023-11-13 14-50-33

@artonge artonge self-assigned this Nov 13, 2023
@artonge artonge added this to the Nextcloud 28 milestone Nov 13, 2023
@artonge artonge requested review from a team, nfebe, sorbaugh, emoral435, susnux and Pytal and removed request for a team and sorbaugh November 13, 2023 13:51
@artonge artonge force-pushed the artonge/fix/live_photo_overlay branch from f6aeb71 to dc16a74 Compare November 13, 2023 14:04
@artonge
Copy link
Contributor Author

artonge commented Nov 13, 2023

/compile amend /

@nextcloud-command nextcloud-command force-pushed the artonge/fix/live_photo_overlay branch from dc16a74 to 44d037e Compare November 13, 2023 15:18
@artonge artonge force-pushed the artonge/fix/live_photo_overlay branch 2 times, most recently from dc16a74 to a96e270 Compare November 13, 2023 17:28
@artonge
Copy link
Contributor Author

artonge commented Nov 13, 2023

/compile amend /

@artonge artonge mentioned this pull request Nov 13, 2023
Merged
@mejo- mejo- mentioned this pull request Nov 13, 2023
Merged
1 task
@artonge artonge enabled auto-merge November 13, 2023 17:44
@nextcloud-command nextcloud-command force-pushed the artonge/fix/live_photo_overlay branch from a96e270 to 78271c1 Compare November 13, 2023 17:47
@artonge
Use background to increase overlay contrast
835c6f8 
And limit it to files

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge force-pushed the artonge/fix/live_photo_overlay branch from 78271c1 to 835c6f8 Compare November 13, 2023 18:10
@artonge
Copy link
Contributor Author

artonge commented Nov 13, 2023

CI failure unrelated

@artonge artonge disabled auto-merge November 13, 2023 21:40
@artonge artonge merged commit 311b8ff into master Nov 13, 2023
@artonge artonge deleted the artonge/fix/live_photo_overlay branch November 13, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@mejo- mejo- mejo- approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@emoral435 emoral435 Awaiting requested review from emoral435 emoral435 was automatically assigned from nextcloud/server-frontend

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug javascript
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @AndyScherzinger @mejo-