-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Filename validation should only forbid create
and update
#47185
Conversation
create
and update
31f20c9
to
7121189
Compare
Hum, so the New button is greyed out because the name of the folder is invalid, but how can the user understand this? |
Its greyed out because the permission does not include "CREATE". Did not change the front end here, could be done in a follow up, but fixing the permissions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as after
is better than before
. But we should make the situation more clear in the UI in my opinion, or we’ll get confused users about why they do not have write access to the folder, and will look into ACLs and storages and file permissions before thinking about a forbidden name on a parent folder.
64a602d
to
fbebd84
Compare
56ca480
to
758ed89
Compare
758ed89
to
601dd76
Compare
/backport to stable30 |
601dd76
to
31e9f1d
Compare
31e9f1d
to
ae720d6
Compare
Test failures seem related, looks like it widely fails on install |
4de2f4c
to
35d6505
Compare
2d1b6a2
to
0c5f5c1
Compare
95bbd4e
to
43a3a6d
Compare
50464d3
to
64db2ef
Compare
/compile / |
Signed-off-by: Ferdinand Thiessen <[email protected]>
Renaming is basically copy + delete (a move), so no need to update permissions. Especially if the node is in a invalid directory the node should be moveable but not editable. Signed-off-by: Ferdinand Thiessen <[email protected]>
Needed to read files with the "Windows compatibility" feature. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
70df5f4
to
9321292
Compare
@susnux now the rename action is shown on trashbin 🤔 server/apps/files_trashbin/lib/Sabre/AbstractTrashFile.php Lines 19 to 21 in afa48a4
Isn't there a cleaner way for permissions? |
|
Summary
isForbidden
must only check full filename - this is used for other purposes (backwards compatibility + fix issues)create
andupdate
) when the node is places within an invalid node.Screen recording
Setup - folder before enabling "Windows support":
Without this ("before")
Bildschirmaufnahme_20240812_182432.webm
With this ("after")
Bildschirmaufnahme_20240812_182149.webm
Checklist