perf: use more optimized way to get user storage info in ocs user info #49476
+78
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
come-nc,
a team,
artonge and
yemkareems
and removed request for
a team
icewind1991
force-pushed
the
ocs-user-info-quota-optimize
branch
2 times, most recently
from
1706c3e to
e004ce7
Compare
yemkareems
approved these changes
Nov 26, 2024
come-nc
reviewed
Nov 26, 2024
icewind1991
force-pushed
the
ocs-user-info-quota-optimize
branch
from
e004ce7 to
a4ed1b0
Compare
made it fallback to the old implementation when |
icewind1991
force-pushed
the
ocs-user-info-quota-optimize
branch
3 times, most recently
from
906b89b to
5958fcc
Compare
come-nc
reviewed
Jan 6, 2025
come-nc
reviewed
Jan 6, 2025
Comment on lines
285
to
286
| /* In case the Exception left things in a bad state */ | ||
| \OC_Util::tearDownFS(); |
There was a problem hiding this comment.
That should still happen if $includeExternal is true, no?
There was a problem hiding this comment.
It is, inside the if ($includeExternal) { block
There was a problem hiding this comment.
But if it throws you still end up in this catch block, or did I miss something?
icewind1991
force-pushed
the
ocs-user-info-quota-optimize
branch
from
5958fcc to
1a913a8
Compare
…o when possible Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
ocs-user-info-quota-optimize
branch
from
1a913a8 to
118ff88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing a full setup etc. We just get quota directly from the user, and the used space directly from the cache.
This means that we only need to setup the home storage for any user, instead of all storages the user has access to.
This does lead to a minor change in behavior, that for users with unlimited quota, the reported quota no longer falls back to the free space in the data directory. As far as I can tell these fields aren't used in the accounts ui and that behavior isn't something that can be relied on anyway, since s3 based setups (and various others) won't have this behavior anyway.