-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve checks for moving shares/storages into other mounts #49552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
mount-move-checks
branch
from
November 29, 2024 13:54
4d65a9f
to
be89374
Compare
Pytal
reviewed
Dec 2, 2024
icewind1991
force-pushed
the
mount-move-checks
branch
3 times, most recently
from
December 16, 2024 14:58
ec3cb28
to
aeeedec
Compare
/compile / |
icewind1991
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Dec 16, 2024
I'll rebase + recompile when approved cause the js files are going to keep conflicting |
skjnldsv
approved these changes
Dec 22, 2024
skjnldsv
requested review from
Pytal,
a team,
susnux and
artonge
and removed request for
a team
December 22, 2024 16:24
sorbaugh
approved these changes
Dec 23, 2024
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
mount-move-checks
branch
from
January 3, 2025 14:36
fb7410e
to
d6418fc
Compare
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
Annoyingly transfer ownership relies on the broken behavior of silently not moving mounts inside folders. Added an option to ignore nested mounts when renaming folders. I hate it but doing it "properly" would be a pain. |
icewind1991
force-pushed
the
mount-move-checks
branch
2 times, most recently
from
January 3, 2025 18:39
e0dbd11
to
df640ee
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
mount-move-checks
branch
from
January 6, 2025 13:45
df640ee
to
757076a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
false
Fixes #44249