Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve checks for moving shares/storages into other mounts #49552

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Nov 28, 2024

  • Also check for any mounts inside moved folders
  • Throw an exception with a meaningful message instead of returning false
  • have the webui show the message instead of a generic error

Fixes #44249

@icewind1991 icewind1991 added the 2. developing Work in progress label Nov 28, 2024
@icewind1991 icewind1991 added this to the Nextcloud 31 milestone Nov 28, 2024
lib/private/Files/View.php Outdated Show resolved Hide resolved
@icewind1991
Copy link
Member Author

/compile /

@icewind1991 icewind1991 marked this pull request as ready for review December 16, 2024 15:06
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 16, 2024
@icewind1991
Copy link
Member Author

I'll rebase + recompile when approved cause the js files are going to keep conflicting

@skjnldsv skjnldsv requested review from Pytal, a team, susnux and artonge and removed request for a team December 22, 2024 16:24
@icewind1991
Copy link
Member Author

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@icewind1991
Copy link
Member Author

Annoyingly transfer ownership relies on the broken behavior of silently not moving mounts inside folders.

Added an option to ignore nested mounts when renaming folders. I hate it but doing it "properly" would be a pain.

@icewind1991 icewind1991 force-pushed the mount-move-checks branch 2 times, most recently from e0dbd11 to df640ee Compare January 3, 2025 18:39
@icewind1991 icewind1991 merged commit ca2e296 into master Jan 6, 2025
188 checks passed
@icewind1991 icewind1991 deleted the mount-move-checks branch January 6, 2025 14:10
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot move shared folders to external storages without parent folder
6 participants