-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change translation logic to handle plurals better #49852
Conversation
/backport to stable30 |
Code added in 30, do not backport further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a squash for clean git history.
Requesting as change so this isn't merged prematurely.
a31501b
to
e0a8d74
Compare
e0a8d74
to
887c258
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not clean. Please rebase when updating the branch instead of merging master into your work branch.
26313ff
to
3e2d890
Compare
3e2d890
to
b88563e
Compare
Signed-off-by: SebastianKrupinski <[email protected]>
b88563e
to
a912556
Compare
We did it, after like 20 attempts 🎉 🎉 🎉 |
🤣 🤣 🤣 Yeah, tell me about it. Now we can have the same fun with the backport |
Summary
Checklist