Add Tests for files UserConfig service #50050
Open
+208
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Not ok: in_array("foo", [true, false]); // returns true
ok: in_array("foo", [true, false], true); // returns false
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
bromiesTM
force-pushed
the
kh/dev/files-userconfig-tests
branch
from
cf27019 to
49d10ed
Compare
come-nc
reviewed
Jan 7, 2025
Comment on lines
+24
to
+40
| /** | ||
| * @var string | ||
| */ | ||
| private $userUID; | ||
|
|
||
| private $userMock; | ||
|
|
||
| /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */ | ||
| private $configMock; | ||
|
|
||
| /** @var IUserSession|\PHPUnit\Framework\MockObject\MockObject */ | ||
| private $userSessionMock; | ||
|
|
||
| /** | ||
| * @var UserConfig|\PHPUnit\Framework\MockObject\MockObject | ||
| */ | ||
| private $userConfigService; |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @var string | |
| */ | |
| private $userUID; | |
| private $userMock; | |
| /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */ | |
| private $configMock; | |
| /** @var IUserSession|\PHPUnit\Framework\MockObject\MockObject */ | |
| private $userSessionMock; | |
| /** | |
| * @var UserConfig|\PHPUnit\Framework\MockObject\MockObject | |
| */ | |
| private $userConfigService; | |
| private string $userUID; | |
| private IUser&MockObject $userMock; | |
| private IConfig&MockObject $configMock; | |
| private IUserSession&MockObject $userSessionMock; | |
| private UserConfig $userConfig; |
| ->withAnyParameters() | ||
| ->willReturn($this->userMock); | ||
|
|
||
| $this->userConfigService = $this->getUserConfigService(['addActivity']); |
There was a problem hiding this comment.
Suggested change
| $this->userConfigService = $this->getUserConfigService(['addActivity']); | |
| $this->userConfig = new UserConfig($this->configMock, $this->userSessionMock); |
Comment on lines
+46
to
+50
| $this->userUID = static::getUniqueID('user_id-'); | ||
| \OC::$server->getUserManager()->createUser($this->userUID, 'test'); | ||
| \OC_User::setUserId($this->userUID); | ||
| \OC_Util::setupFS($this->userUID); | ||
| $this->userMock = $this->getUserMock($this->userUID); |
There was a problem hiding this comment.
Is all this needed? 🤔
Looks ugly and calls obsolete methods.
Comment on lines
+103
to
+104
| $userConfig = new UserConfig($this->configMock, $this->userSessionMock); | ||
| $userConfig->setConfig('crop_image_previews', true); |
There was a problem hiding this comment.
Suggested change
| $userConfig = new UserConfig($this->configMock, $this->userSessionMock); | |
| $userConfig->setConfig('crop_image_previews', true); | |
| $this->userConfig->setConfig('crop_image_previews', true); |
There was a problem hiding this comment.
And same for the other ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
Screenshots before/after for front-end changes