Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PresenterOverlay): do not move component to negative values #14369

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix placing presenter video out of visible bounds while screensharing
  • Parent size is recalculated after mounting, which results in smaller parentHeight than actual -> moveVertically pushes it behind the CallView

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before

2025-02-13_10h07_46.mp4

🏡 After

2025-02-13_10h05_46.mp4

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Feb 13, 2025
@Antreesy Antreesy self-assigned this Feb 13, 2025
@Antreesy
Copy link
Contributor Author

/backport to stable31

@ShGKme
Copy link
Contributor

ShGKme commented Feb 13, 2025

Is it guaranteed that the value is initially (before update trigger) are in the valid range?

@Antreesy
Copy link
Contributor Author

Is it guaranteed that the value is initially (before update trigger) are in the valid range?

I don't think so. Caught it in the moment of transition (Grid component), believe, that issue might originate from here:
image

@nickvergessen nickvergessen merged commit 512f5b2 into main Feb 13, 2025
53 checks passed
@nickvergessen nickvergessen deleted the fix/noid/presenter-out-of-bounds branch February 13, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants