-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix internal links in direct-edit sessions #3442
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
487ac9c
to
0b1ef07
Compare
2 flaky tests on run #8762 ↗︎
Details:
sync.spec.js • 1 flaky test
viewer.spec.js • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Cypress failures are unrelated. Will push a fix for a recent server change shortly. |
Fix in nextcloud/server#35866 |
0b1ef07
to
0c2dcdf
Compare
0c2dcdf
to
2c66901
Compare
I tried to create a cypress test for this here: https://github.com/nextcloud/text/tree/test/direct-editing-with-link But the test won't fail even with the current master. So i am obviously failing to understand somethign about the underlying problem. Could you take a look at the test and check what i am missing? |
@juliushaertl is this PR still ready to be merged? Since you approved it earlier, is there a reason not to merge it? |
2c66901
to
f350fcf
Compare
Signed-off-by: Raul <[email protected]>
f350fcf
to
9957d99
Compare
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Nothing blocking from my side, let's get this in |
📝 Summary
Internal links previously relied on OCA.Viewer to fetch the relative path of the document. In direct-edit sessions OCA.Viewer is not set.
This PR adds a check for OCA.Viewer before handling internal links.
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)