Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dependencies): force react-filerobot-image-editor@^4.3.8 #1574

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix(dependencies): force react-filerobot-image-editor@^4.3.8 #1574

merged 1 commit into from
Mar 7, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 7, 2023

@skjnldsv skjnldsv added bug Something isn't working design Related to the design 3. to review Waiting for reviews labels Mar 7, 2023
@skjnldsv skjnldsv added this to the Nextcloud 27 milestone Mar 7, 2023
@skjnldsv skjnldsv self-assigned this Mar 7, 2023
@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 7, 2023

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Mar 7, 2023
@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 7, 2023

/backport to stable25

@skjnldsv skjnldsv added the dependencies Pull requests that update a dependency file label Mar 7, 2023
@skjnldsv skjnldsv requested review from a team, artonge, Pytal and szaimen and removed request for a team March 7, 2023 15:39
@szaimen
Copy link
Contributor

szaimen commented Mar 7, 2023 •
edited
Loading

@skjnldsv how is it possible that the packages.lock was seemingly not updated during #1547 or is this some other dependency?

Edit: this seemingly was stable25 or no?

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 7, 2023

@skjnldsv how is it possible that the packages.lock was seemingly not updated during #1547 or is this some other dependency?

Also different: react-filerobot-image-editor !== filerobot-image-editor

szaimen
szaimen approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This crops the previews correctly in my testing:
image

@skjnldsv skjnldsv merged commit 8ecc91f into master Mar 7, 2023
@skjnldsv skjnldsv deleted the fix/react-filerobot-image-editor branch March 7, 2023 15:53
This was referenced Mar 7, 2023
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working dependencies Pull requests that update a dependency file design Related to the design
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @szaimen