Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fallback to manually loading media on error #2691

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jan 16, 2025

This is needed for E2EE files that will error when loading them directly from the HTML element's src attribute.

@artonge artonge self-assigned this Jan 16, 2025
@artonge artonge requested a review from skjnldsv January 16, 2025 10:43
@artonge artonge added 3. to review Waiting for reviews javascript Javascript related ticket bug Something isn't working labels Jan 16, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 16, 2025
@artonge artonge force-pushed the artonge/feat/use_get_to_display_files branch from 00eb536 to db645dc Compare January 16, 2025 11:15
@artonge
Copy link
Contributor Author

artonge commented Jan 16, 2025

/compile /

This is needed for E2EE files that will error when loading them directly from the HTML element's src attribute.

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/use_get_to_display_files branch from 7399c6e to 8ecef66 Compare January 16, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant