feat(iterators): add GuildIterator.with_counts
#1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spifory
force-pushed
the
spifory/fix/add-with-counts-param
branch
2 times, most recently
from
855311e to
405e5f6
Compare
spifory
force-pushed
the
spifory/fix/add-with-counts-param
branch
from
08b270c to
984b1c5
Compare
|
I accidentally made this branch off of another branch, and not master, so that is the reason for the force-pushes |
spifory
added
t: enhancement
I'm not even sure what happened here
teaishealthy
requested changes
Jul 26, 2023
Co-authored-by: teaishealthy <[email protected]>
EmmmaTech
requested changes
Aug 12, 2023
Co-authored-by: Emre Terzioglu <[email protected]>
EmmmaTech
requested changes
Aug 13, 2023
ooliver1
approved these changes
Aug 25, 2023
ooliver1
removed
the
s: awaiting review
EmmmaTech
added a commit
to EmmmaTech/nextcord
that referenced
this pull request
Sep 17, 2023
vcokltfre
pushed a commit
that referenced
this pull request
Dec 24, 2024
* refactor!: rewrite async iterators to not use classes * refactor!: rewrite ban & audit log iterators * docs: represent changes in Reaction.users docstring * refactor!: finish iterator rewrite * style: auto fixes from pre-commit hooks * refactor: update audit log iterators * style: auto fixes from pre-commit hooks * docs: add python doc references for async iterators * style: auto fixes from pre-commit hooks * typing: fix pyright errors * style: auto fixes from pre-commit hooks * fix(Guild.audit_logs): value of enum was passed into iterator * refactor(utils)!: remove chunk in favor of as_chunks * docs(iterators.py): add versionchanged * refactor: rewrite iterators to reflect original code * style: auto fixes from pre-commit hooks * feat: port #1093 * style: auto fixes from pre-commit hooks * style: auto fixes from pre-commit hooks * style: resolve ruff errors * style: auto fixes from pre-commit hooks * refactor(utils)!: remove anext helper nextcord maintainers have officially stated that the next version will have a 3.12 version minimum, which contains the builtin anext function. * docs: forgot asynciter tag * refactor: code smell, switch back to `reversed` for reversing data in an earlier state of this pr, I switched any iterator that used the reversed tool to sorting the list with the id as a key. however, from my own tests, this strategy does not work as expected. therefore, I have reverted it. * style: auto fixes from pre-commit hooks * docs: remove obsolete AsyncIterator class * refactor(history iterator): remove obsolete 101 limit check --------- Co-authored-by: EmreTech <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Oliver Wilkes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements discord/discord-api-docs#5628
In case you're wondering, "why is the default for
with_countsFalse?"Well that is because the default on the documentation
false, so just for the sake of consistency, that is why the default isFalse.This is a Code Change
task pyrightand fixed the relevant issues.