Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support hyphen values for --build-jobs #1874

Merged

Conversation

mattsse
Copy link
Contributor

@mattsse mattsse commented Nov 15, 2024

cargo --jobs supports negative values: rust-lang/cargo#9217

currently this fails:

cargo nextest run --build-jobs -1                                                                                                                                                                                                   
error: unexpected argument '-1' found

  tip: to pass '-1' as a value, use '-- -1'

because clap doesn't support this by default and requires allow_hyphen_values = true

clap-rs/clap#1245

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.65%. Comparing base (f6064a0) to head (8d6c414).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1874   +/-   ##
=======================================
  Coverage   79.64%   79.65%           
=======================================
  Files          80       80           
  Lines       20406    20409    +3     
=======================================
+ Hits        16253    16256    +3     
  Misses       4153     4153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunshowers
Copy link
Member

sunshowers commented Nov 15, 2024

Thank you! Could you also add a test here?

let valid: &[&'static str] = &[

@sunshowers sunshowers merged commit 8530c1a into nextest-rs:main Nov 15, 2024
17 of 18 checks passed
@sunshowers
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants