Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support [profile.default-llvm-cov] #857

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

def-
Copy link

@def- def- commented Apr 21, 2023

Depends on taiki-e/cargo-llvm-cov#259 (edit: has been released)

This is done similarly for miri and makes sense since both increase running times.

Depends on taiki-e/cargo-llvm-cov#259

This is done similarly for miri and makes sense since both increase running times.
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #857 (500b9d2) into main (99a5f42) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   77.42%   77.42%   -0.01%     
==========================================
  Files          67       67              
  Lines       13371    13373       +2     
==========================================
+ Hits        10353    10354       +1     
- Misses       3018     3019       +1     
Impacted Files Coverage Δ
nextest-runner/src/config/config_impl.rs 93.58% <ø> (ø)
cargo-nextest/src/dispatch.rs 82.65% <50.00%> (-0.06%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sunshowers
Copy link
Member

sunshowers commented Apr 21, 2023

Thanks for the PR!

Hmm, wouldn't this need to also include the settings for llvm-cov in default-config.toml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants