Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relationships: make HasOne relationship lazy until entity is attached #467

Merged
merged 2 commits into from
Oct 20, 2020
Merged

relationships: make HasOne relationship lazy until entity is attached #467

merged 2 commits into from
Oct 20, 2020

Conversation

hrach
Copy link
Member

@hrach hrach commented Oct 19, 2020 •
edited
Loading

  • consider calling setParentEntity just once after entity is attached

@hrach hrach force-pushed the lazy-relationships branch from 250912d to c8f90e3 Compare October 19, 2020 21:49
@hrach hrach added the feature label Oct 19, 2020
hrach
hrach commented Oct 19, 2020
View reviewed changes
src/Relationships/HasOne.php Outdated Show resolved Hide resolved
@hrach hrach marked this pull request as ready for review October 20, 2020 20:59
@hrach hrach force-pushed the lazy-relationships branch from c8f90e3 to c722a69 Compare October 20, 2020 20:59
@hrach hrach merged commit 92d502e into master Oct 20, 2020
@hrach hrach deleted the lazy-relationships branch October 20, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hrach