Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging same JOINs together & introduction of independent JOINs #542

Merged
merged 2 commits into from
Dec 11, 2021
Merged

Conversation

hrach
Copy link
Member

@hrach hrach commented Nov 19, 2021

Merged as part of #545:

  • rework DbalJoinEntry
  • merge join conditions targeting the same table (alias)
  • remove the same on-expression duplicates
  • defer JOINs materialization to SQL in DbalCollection
  • rework repeated findBy() calls to reuse ICollection::AND infrastructure to utilize JOINs merging

Merged as part of #546:

  • unify groupBy handling via DbalJoinEntry
  • refactor aggregators to instance passing instead of custom collection function handling (rework aggregators to single implementation)
  • refactor Array to properly implement aggregation on *Junction level
  • fix Array handling dependent aggregated conditions
  • move/add table alias handling for IAggregator
  • allow passing custom table aggregation logic

This PR:

  • wire IAggregation key to table aliasing logic in Dbal

Closes #541
Closes #526

@hrach hrach added this to the v5.0 milestone Nov 22, 2021
@hrach hrach self-assigned this Nov 22, 2021
@hrach hrach force-pushed the joins branch 2 times, most recently from e1a1204 to 2f44be2 Compare November 23, 2021 23:26
@hrach hrach changed the title Joins Merging same JOINs together & introduction of independent JOINs Nov 23, 2021
@hrach hrach force-pushed the joins branch 2 times, most recently from a40462e to 508599a Compare November 26, 2021 23:47
@hrach hrach mentioned this pull request Dec 7, 2021
@hrach hrach marked this pull request as ready for review December 11, 2021 16:04
@hrach hrach merged commit 26b6d8d into main Dec 11, 2021
@hrach hrach deleted the joins branch December 11, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant