Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with nette/application 3.1.5 #33

Closed
natocTo opened this issue Jan 6, 2022 · 3 comments · Fixed by #34
Closed

Incompatibility with nette/application 3.1.5 #33

natocTo opened this issue Jan 6, 2022 · 3 comments · Fixed by #34

Comments

@natocTo
Copy link
Contributor

natocTo commented Jan 6, 2022 •
edited
Loading

Tento PR #31 co se dělal pro verzi 3.1.4 nefunguje na verzi 3.1.5 https://github.com/nette/application/releases/tag/v3.1.5.
Vypadá že tam někdo reportoval že to byl asi BC break tak se to vrátilo do stavu jak to bylo před verzí 3.1.4.

Nevím zda by stačil revert toho PR pouze nebo už není žádoucí vracet PHP 7.1.
@hrach
Copy link
Member

hrach commented Jan 6, 2022

Uz bych PHP 7.1 nevracel. Poslani PR pomuze :)

@natocTo natocTo mentioned this issue Jan 6, 2022
Merged
@Ivorius
Copy link
Contributor

Ivorius commented Jan 24, 2022

Šlo by to vydat?

@hrach hrach closed this as completed in #34 Jan 24, 2022
@hrach
Copy link
Member

hrach commented Jan 24, 2022

Published as 1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync SecuredLinksControlTrait::link() with nette/application 3.1.5+ natocTo/secured-links
3 participants
@hrach @Ivorius @natocTo