Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync SecuredLinksControlTrait::link() with nette/application 3.1.4+ #31

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Sync SecuredLinksControlTrait::link() with nette/application 3.1.4+ #31

merged 1 commit into from
Oct 9, 2021

Conversation

forgie1
Copy link
Contributor

@forgie1 forgie1 commented Oct 9, 2021

No description provided.

@hrach
Copy link
Member

hrach commented Oct 9, 2021

Thank you! Please bump also required PHP version to 7.2 since:

  Problem 1
    - Root composer.json requires nette/application ^3.1.4 -> satisfiable by nette/application[v3.1.4].
    - nette/application v3.1.4 requires php >=7.2 -> your php version (7.1.33) does not satisfy that requirement.

@hrach
Copy link
Member

hrach commented Oct 9, 2021

(remove the version from github workflow and change in composer)

@forgie1
Copy link
Contributor Author

forgie1 commented Oct 9, 2021

Done :)

@hrach hrach merged commit d4618db into nextras:master Oct 9, 2021
@hrach
Copy link
Member

hrach commented Oct 9, 2021

Thank you!

@hrach hrach mentioned this pull request Oct 11, 2021
Closed
@natocTo natocTo mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forgie1 @hrach