Add Secured as attribute for PHP >= 8.0 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrach
reviewed
Nov 15, 2022
src/SecuredLinksControlTrait.php
Outdated
| @@ -41,7 +41,7 @@ public function signalReceived(string $signal): void | |||
|
|
|||
| if (method_exists($this, $method)) { | |||
| $reflection = new \ReflectionMethod($this, $method); | |||
| $secured = Nette\Application\UI\ComponentReflection::parseAnnotation($reflection, 'secured') !== NULL; | |||
| $secured = Nette\Application\UI\ComponentReflection::parseAnnotation($reflection, 'secured') !== NULL || count($reflection->getAttributes(Secured::class)) > 0; | |||
There was a problem hiding this comment.
This needs to be iffed / or possibly, just remove support for PHP<8.0.
There was a problem hiding this comment.
Weird that phpstan is ok with this.
There was a problem hiding this comment.
Dropping PHP<8.0 should be your call in this project :-)
I will add the iffs. What confused me is that tests passed for PHP<8, but that's because tests currently don't cover this part of code, maybe?
There was a problem hiding this comment.
@hrach Added method_exists.
Also added test coverage for signalReceived, wasn't covered before.
Only covers @secured, not #[Secured] at the moment.
|
Awesome, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0 brings a new backward compatible way to replace annotations.
This PR adds support for attribute
#[Secured]or#[\Nextras\Application\UI\Secured]to be used instead of annotation@secured.