Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trim multiqc #440

Merged
merged 18 commits into from
Nov 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Fix channel i/o issue in StringTie workflow and add StringTie in github CI tests [#416](https://github.com/nf-core/rnafusion/pull/416)
- Updated COSMIC database to fix 404 error while downloading fusionreport references [#420](https://github.com/nf-core/rnafusion/pull/420)
- Update modules, and make sure MultiQC displays the QC results properly [#440](https://github.com/nf-core/rnafusion/pull/440)
- Add 'when' condition to run collectinsertsize [#444](https://github.com/nf-core/rnafusion/pull/444)

### Removed
Expand Down
30 changes: 0 additions & 30 deletions assets/multiqc_config.yaml

This file was deleted.

29 changes: 27 additions & 2 deletions assets/multiqc_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,34 @@ report_comment: >
<a href="https://nf-co.re/rnafusion/dev/docs/output" target="_blank">documentation</a>.

report_section_order:
software_versions:
nf-core-rnafusion-methods-description:
order: -1000
nf-core-rnafusion-summary:
software_versions:
order: -1001
nf-core-rnafusion-summary:
order: -1002

export_plots: true

# Run only these modules
run_modules:
- custom_content
- fastqc
- fastp
- star
- samtools
- picard
- arriba

module_order:
- fastp
- fastqc:
name: "FastQC (raw)"
info: "This section of the report shows FastQC results before adapter trimming."
path_filters:
- "*.zip"
- fastqc:
name: "FastQC (trimmed)"
info: "This section of the report shows FastQC results after adapter trimming."
path_filters:
- "*_trimmed*.zip"
10 changes: 8 additions & 2 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,18 @@ process {
withName: FASTQC {
ext.args = '--quiet'
ext.when = { !params.skip_qc }
publishDir = [
path: { "${params.outdir}/fastqc" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
}

withName: FASTQC_FOR_TRIM {
withName: FASTQC_FOR_FASTP {
rannick marked this conversation as resolved.
Show resolved Hide resolved
ext.args = '--quiet'
ext.prefix = { "${meta.id}_trimmed" }
publishDir = [
path: { "${params.outdir}/fastqc_for_trim" },
path: { "${params.outdir}/fastqc_for_fastp" },
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
Expand Down
4 changes: 2 additions & 2 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
},
"multiqc": {
"branch": "master",
"git_sha": "214d575774c172062924ad3564b4f66655600730",
"git_sha": "1537442a7be4a78efa3d1ff700a923c627bbda5d",
"installed_by": ["modules"]
},
"picard/collectinsertsizemetrics": {
Expand All @@ -77,7 +77,7 @@
},
"samtools/index": {
"branch": "master",
"git_sha": "3f5420aa22e00bd030a2556dfdffc9e164ec0ec5",
"git_sha": "5394565c5fe4c760e5b35977ec7607c62e81d1f8",
"installed_by": ["modules"]
},
"samtools/sort": {
Expand Down
2 changes: 1 addition & 1 deletion modules/nf-core/multiqc/environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions modules/nf-core/multiqc/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

91 changes: 91 additions & 0 deletions modules/nf-core/multiqc/tests/main.nf.test

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions modules/nf-core/multiqc/tests/tags.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions modules/nf-core/samtools/index/tests/csi.nextflow.config

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

87 changes: 87 additions & 0 deletions modules/nf-core/samtools/index/tests/main.nf.test

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions modules/nf-core/samtools/index/tests/main.nf.test.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions modules/nf-core/samtools/index/tests/tags.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion subworkflows/local/fusioninspector_workflow.nf
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ workflow FUSIONINSPECTOR_WORKFLOW {

main:
ch_versions = Channel.empty()
ch_arriba_visualisation = Channel.empty()
index ="${params.starfusion_ref}"

ch_fusion_list = ( params.tools_cutoff > 1 ? fusion_list_filtered : fusion_list )
Expand Down Expand Up @@ -53,9 +54,11 @@ workflow FUSIONINSPECTOR_WORKFLOW {
ch_bam_sorted_indexed_fusions = bam_sorted_indexed.join(FUSIONINSPECTOR.out.tsv)
ARRIBA_VISUALISATION(ch_bam_sorted_indexed_fusions, ch_gtf, ch_arriba_ref_protein_domains, ch_arriba_ref_cytobands)
ch_versions = ch_versions.mix(ARRIBA_VISUALISATION.out.versions)
ch_arriba_visualisation = ARRIBA_VISUALISATION.out.pdf
}

emit:
versions = ch_versions.ifEmpty(null)
ch_arriba_visualisation
versions = ch_versions.ifEmpty(null)
}

Loading