Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] StudyFile.Study.fromFile returns some empty lists in the resulting study #71

Closed
omaus opened this issue Dec 1, 2022 · 0 comments · Fixed by #72
Closed

[BUG] StudyFile.Study.fromFile returns some empty lists in the resulting study #71

omaus opened this issue Dec 1, 2022 · 0 comments · Fixed by #72
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@omaus
Copy link
Collaborator

omaus commented Dec 1, 2022

Describe the bug
StudyFile.Study.fromFile returns some empty lists in the resulting study in record fields

  • .Protocols
  • .ProcessSequence
  • .Factors
  • .CharacteristicCategories

To Reproduce
Steps to reproduce the behavior:

  1. Create a study with the ArcCommander
  2. Load it via StudyFile.Study.fromFile
  3. See empty lists

Expected behavior
Nones instead of Some []s.

Screenshots
The difference between the same study, once from the Study file itself (top) and once from the Investigation file (bottom):
image
@omaus omaus added the Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. label Dec 1, 2022
HLWeil added a commit that referenced this issue Dec 2, 2022
@HLWeil
fix study xlsx reader creating empty lists
8f63206 
#71
@HLWeil HLWeil mentioned this issue Dec 2, 2022
Merged
@HLWeil HLWeil closed this as completed in #72 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Small fixes and changes nfdi4plants/ARCtrl
1 participant
@omaus