-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with ESM #102
Labels
Comments
Use esbuild instead since it supports ts natively and is made for bundling : #105 |
Sadly AWS lambda support is fake since the layers doesn't support ESM... see https://github.com/vibe/aws-esm-modules-layer-support |
Jest is not supporting ESM fully, will lurk its progress: jestjs/jest#14923 |
nfroidure
added a commit
that referenced
this issue
Feb 27, 2024
Some things still needs to be fixed like Jest and AWS Lambda/CGP builds to use ESM too. BREAKING CHANGE: Will require Node 20 since it relies on its ESM support. Also, the `PROJECT_SRC` constant is removed and the `INITIALIZER_PATHS_MAP` constant is now supposed to have well designed paths in it. #102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Node14 now supports ESM, when AWSLambda and GCP will upgrade to it, we will be able to build ESM modules. Here is a to do list to achieve this:
type: 'module'
inpackage.json
https://nodejs.org/api/packages.html#packages_type and .js files are ESM , ensure imports have file extension Webpack 5 support. ESM strict mode JedWatson/react-select#4253 )common-services
to resolve modules withimport.meta
Make theresolve
service useimport.meta.resolve
common-services#20ts-node
: (maybe use tsxThe text was updated successfully, but these errors were encountered: