Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no more object with slash for CID #42

Merged
merged 2 commits into from
Apr 8, 2022
Merged

fix: no more object with slash for CID #42

merged 2 commits into from
Apr 8, 2022

Conversation

alanshaw
Copy link

@alanshaw alanshaw commented Apr 5, 2022 •
edited by olizilla
Loading

As of [email protected]

Cids are JSON-ified as '"Qm...."' instead of '{ "/": "Qm....." }'

see: ipfs-cluster/ipfs-cluster#1626

@olizilla
Copy link
Contributor

olizilla commented Apr 7, 2022

The motivating change for this PR has landed in [email protected] ipfs-cluster/ipfs-cluster#1626

@olizilla olizilla self-assigned this Apr 7, 2022
@olizilla
chore: update to [email protected]
3c0c3bd 
License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <[email protected]>
@olizilla olizilla marked this pull request as ready for review April 7, 2022 20:53
@olizilla olizilla requested a review from vasco-santos April 8, 2022 11:11
@olizilla olizilla mentioned this pull request Apr 8, 2022
Closed
14 tasks
vasco-santos
vasco-santos approved these changes Apr 8, 2022
View reviewed changes
Copy link

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olizilla olizilla changed the title refactor: no more object with slash for CID fix: no more object with slash for CID Apr 8, 2022
@olizilla olizilla merged commit e078957 into main Apr 8, 2022
@olizilla olizilla deleted the refactor/no-more-object-slash-cid0 branch April 8, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

Assignees

@olizilla olizilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanshaw @olizilla @vasco-santos