Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface deal data selector in client #192

Closed
alanshaw opened this issue Jun 17, 2021 · 1 comment · Fixed by #198
Closed

Surface deal data selector in client #192

alanshaw opened this issue Jun 17, 2021 · 1 comment · Fixed by #198
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@alanshaw
Copy link
Contributor

alanshaw commented Jun 17, 2021 •
edited
Loading

The deal data selector is now available so if folks actually want to retrieve data from Filecoin they'll soon be able to use this (🔜 currently needs custom lotus client filecoin-project/lotus#6393).

image
@alanshaw alanshaw added kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours status/ready Ready to be worked labels Jun 17, 2021
alanshaw pushed a commit that referenced this issue Jun 18, 2021
feat: deal data selector
78197af 
The deal data selector is now available so if folks actually want to retrieve data from Filecoin they'll soon be able to use this (🔜 currently needs custom lotus client filecoin-project/lotus#6393).

resolves #192
@alanshaw alanshaw mentioned this issue Jun 18, 2021
Merged
alanshaw pushed a commit that referenced this issue Jun 18, 2021
feat: deal data selector (#198)
7261c53 
The deal data selector is now available so if folks actually want to retrieve data from Filecoin they'll soon be able to use this (🔜 currently needs custom lotus client filecoin-project/lotus#6393).

resolves #192
@askender
Copy link

askender commented Mar 4, 2022

How to get the real deal data selector ? such as /Links/0/Hash ?
How did you generate the image you posted? @alanshaw

I didn't find the doc related to --data-selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: deal data selector nftstorage/nft.storage
2 participants
@alanshaw @askender