Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create cron nft-ttr to measure nft time to retrievability #1945
feat: create cron nft-ttr to measure nft time to retrievability #1945
Changes from 98 commits
45e8abf
e4d0d22
9c968d9
82f97a5
e6cfff9
8bff205
5d484b1
a24f5aa
d84e70b
35a4913
b986dab
4f3051a
3d319c8
b425e50
f2fc920
a1d3ede
1b340e3
2a575f3
08f1f62
854a282
03fbab9
6f1cd2c
a40a696
d4d4cd0
176ebea
8a343f5
6515072
9e686d7
53b43b7
efa794b
ff1d696
b7d958b
f7f9755
c27d229
74b91ce
1a5d930
b4e2528
9ddccc6
501b79d
398090a
6ee4020
ff5d3c4
4267950
4a27271
a1fd2a3
f9ef640
88cf750
0ee9e6c
ee2c3ba
7d543fa
18c9fd6
4a643a0
280045a
f2450cc
4f584aa
40a19e6
7484929
6642e35
82b07a4
d393637
9463cc8
4b37443
bb6bc88
49d89e8
0e46d96
c25529b
a8528ae
726a7a4
1f5e764
4822448
86986c6
f5072e2
14d8ad2
486fdcd
5b5f341
2a03744
5c2c7f5
fec755c
7035dae
2a5592a
94e43e3
48c4330
e7e5db5
c2256b1
de7ed04
5e5ee27
d42d952
440e07e
ab441c9
4007e42
2c852e2
835d77a
14449d8
511e16c
d3fff4b
fbfe265
17f840a
6836369
1aea9c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this
nohoist
change? Unless it causing an issue, can we move to a separate PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was causing an issue I believe. I will verify it's really required now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wasn't required. :/ ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you follow up with a PR to fix the linter issues and remove all this configuration? 🙏🙏🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thing. didn't want to lint those old files prematurely until you weighed in on the lint rules at hand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanshaw this would do it. Not sure if you want to review in here or out. gobengo#1